Skip to content

Further workaround for priority mishandling in runtime. #38427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

varungandhi-apple
Copy link
Contributor

See rdar://79378762, SR-14802, SR-14841, SR-14875.

This doesn't resolve all hangs, such as those occurring
due to explicit usage of priorities and certain other
situations where priorities seem to be causing issues
(rdar://79823345), but it does resolve some cases.

See rdar://79378762, SR-14802, SR-14841, SR-14875.

This doesn't resolve all hangs, such as those occurring
due to explicit usage of priorities and certain other
situations where priorities seem to be causing issues
(rdar://79823345), but it does resolve some cases.
@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@aschwaighofer
Copy link
Contributor

@swift-ci smoke test linux

@aschwaighofer
Copy link
Contributor

The failure on linux looks unrelated:

Test Case 'BuildPlanTests.testExplicitSwiftPackageBuild' started at 2021-07-16 10:56:40.049
SwiftDriver/ClangVersionedDependencyResolution.swift:165: Fatal error: Unresolved placeholder dependencies at planning stage: swiftPlaceholder("C")
Exited with signal code 4

@aschwaighofer
Copy link
Contributor

@swift-ci smoke test linux

@varungandhi-apple
Copy link
Contributor Author

Landing tracked by rdar://80688213.

@varungandhi-apple
Copy link
Contributor Author

Linux failure fix is tracked by #38434

@varungandhi-apple
Copy link
Contributor Author

@swift-ci smoke test

@aschwaighofer
Copy link
Contributor

@swift-ci Please test windows

@varungandhi-apple varungandhi-apple merged commit 72909bd into swiftlang:main Jul 22, 2021
@varungandhi-apple varungandhi-apple deleted the vg-workaround-priority branch July 22, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants